linux-kernel - Re: [RFC 0/6] Module for tracking/accounting shared memory buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAF6AEGvAqpxY4pguzGL9ztQvTCG-tOZhF093Odt0-gt1MM49iQ@mail.gmail.com>
Date:   Tue, 11 Oct 2016 21:14:20 -0400
From:   Rob Clark <robdclark@...il.com>
To:     Ruchi Kandoi <kandoiruchi@...gle.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Riley Andrews <riandrews@...roid.com>,
        Sumit Semwal <sumit.semwal@...aro.org>,
        Arnd Bergmann <arnd@...db.de>, labbott@...hat.com,
        Al Viro <viro@...iv.linux.org.uk>, jlayton@...chiereds.net,
        bfields@...ldses.org, mingo@...hat.com,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        keescook@...omium.org, mhocko@...e.com, oleg@...hat.com,
        John Stultz <john.stultz@...aro.org>, mguzik@...hat.com,
        jdanis@...gle.com, adobriyan@...il.com,
        Greg Hackmann <ghackmann@...gle.com>,
        kirill.shutemov@...ux.intel.com, vbabka@...e.cz,
        dave.hansen@...ux.intel.com,
        Dan Williams <dan.j.williams@...el.com>, hannes@...xchg.org,
        iamjoonsoo.kim@....com, luto@...nel.org, tj@...nel.org,
        vdavydov.dev@...il.com, ebiederm@...ssion.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devel@...verdev.osuosl.org,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
        linux-fsdevel@...r.kernel.org, linux-mm <linux-mm@...ck.org>
Subject: Re: [RFC 0/6] Module for tracking/accounting shared memory buffers

On Tue, Oct 11, 2016 at 7:50 PM, Ruchi Kandoi <kandoiruchi@...gle.com> wrote:
> This patchstack introduces a new "memtrack" module for tracking and accounting
> memory exported to userspace as shared buffers, like dma-buf fds or GEM handles.

btw, I wouldn't care much about the non-dmabuf case.. dri2/flink is
kind of legacy and the sharing patterns there are not so complex that
we have found the need for any more elaborate debug infrastructure
than what we already have.

Between existing dmabuf debugfs, and /proc/*/maps (and /proc/*/fd?), I
wonder what is missing?  Maybe there is a less intrusive way to get at
the debugging info you want?

BR,
-R

> Any process holding a reference to these buffers will keep the kernel from
> reclaiming its backing pages.  mm counters don't provide a complete picture of
> these allocations, since they only account for pages that are mapped into a
> process's address space.  This problem is especially bad for systems like
> Android that use dma-buf fds to share graphics and multimedia buffers between
> processes: these allocations are often large, have complex sharing patterns,
> and are rarely mapped into every process that holds a reference to them.
>
> memtrack maintains a per-process list of shared buffer references, which is
> exported to userspace as /proc/[pid]/memtrack.  Buffers can be optionally
> "tagged" with a short string: for example, Android userspace would use this
> tag to identify whether buffers were allocated on behalf of the camera stack,
> GL, etc.  memtrack also exports the VMAs associated with these buffers so
> that pages already included in the process's mm counters aren't double-counted.
>
> Shared-buffer allocators can hook into memtrack by embedding
> struct memtrack_buffer in their buffer metadata, calling
> memtrack_buffer_{init,remove} at buffer allocation and free time, and
> memtrack_buffer_{install,uninstall} when a userspace process takes or
> drops a reference to the buffer.  For fd-backed buffers like dma-bufs, hooks in
> fdtable.c and fork.c automatically notify memtrack when references are added or
> removed from a process's fd table.
>
> This patchstack adds memtrack hooks into dma-buf and ion.  If there's upstream
> interest in memtrack, it can be extended to other memory allocators as well,
> such as GEM implementations.
>
> Greg Hackmann (1):
>   drivers: staging: ion: add ION_IOC_TAG ioctl
>
> Ruchi Kandoi (5):
>   fs: add installed and uninstalled file_operations
>   drivers: misc: add memtrack
>   dma-buf: add memtrack support
>   memtrack: Adds the accounting to keep track of all mmaped/unmapped
>     pages.
>   memtrack: Add memtrack accounting for forked processes.
>
>  drivers/android/binder.c                |   4 +-
>  drivers/dma-buf/dma-buf.c               |  37 +++
>  drivers/misc/Kconfig                    |  16 +
>  drivers/misc/Makefile                   |   1 +
>  drivers/misc/memtrack.c                 | 516 ++++++++++++++++++++++++++++++++
>  drivers/staging/android/ion/ion-ioctl.c |  17 ++
>  drivers/staging/android/ion/ion.c       |  60 +++-
>  drivers/staging/android/ion/ion_priv.h  |   2 +
>  drivers/staging/android/uapi/ion.h      |  25 ++
>  fs/file.c                               |  38 ++-
>  fs/open.c                               |   2 +-
>  fs/proc/base.c                          |   4 +
>  include/linux/dma-buf.h                 |   5 +
>  include/linux/fdtable.h                 |   4 +-
>  include/linux/fs.h                      |   2 +
>  include/linux/memtrack.h                | 130 ++++++++
>  include/linux/mm.h                      |   3 +
>  include/linux/sched.h                   |   3 +
>  kernel/fork.c                           |  23 +-
>  19 files changed, 875 insertions(+), 17 deletions(-)
>  create mode 100644 drivers/misc/memtrack.c
>  create mode 100644 include/linux/memtrack.h
>
> --
> 2.8.0.rc3.226.g39d4020
>