linux-kernel - Re: [PATCH 1/2] driver core: skip removal test for non-removable drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3cf619c-ca0c-2089-fa4d-db8c2f0e2bc4@redhat.com>
Date:   Wed, 12 Oct 2016 09:10:22 +0200
From:   Laszlo Ersek <lersek@...hat.com>
To:     Rob Herring <robh@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] driver core: skip removal test for non-removable
 drivers

Hi Rob,

On 10/11/16 20:41, Rob Herring wrote:
> Some drivers do not support removal/unbinding. These drivers should have
> drv->suppress_bind_attrs set to true, so use that to skip the removal
> test.
> 
> This doesn't fix anything reported so far, but should prevent some other
> cases. Some drivers will need fixes to set suppress_bind_attrs to avoid
> this test.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=177021
> Fixes: bea5b158ff0d ("driver core: add test of driver remove calls during probe")
> Reported-by: Laszlo Ersek <lersek@...hat.com>
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>  drivers/base/dd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> index d22a7260f42b..8937a7ad7165 100644
> --- a/drivers/base/dd.c
> +++ b/drivers/base/dd.c
> @@ -324,7 +324,8 @@ static int really_probe(struct device *dev, struct device_driver *drv)
>  {
>  	int ret = -EPROBE_DEFER;
>  	int local_trigger_count = atomic_read(&deferred_trigger_count);
> -	bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE);
> +	bool test_remove = IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE) &&
> +			   !drv->suppress_bind_attrs;
>  
>  	if (defer_all_probes) {
>  		/*
> 

can you please repost the full series with me CC'd on all of the
messages; I'm not subscribed to LKML.

Thanks,
Laszlo