linux-kernel - Re: [PATCH] sc16is7xx: Drop bogus use of IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 01:48:20 +0100
From:   Jakub Kicinski <kubakici@...pl>
To:     Julia Cartwright <julia@...com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Sean Nyekjaer <sean.nyekjaer@...vas.dk>,
        Josh Cartwright <joshc@...com>, linux-rt-users@...r.kernel.org,
        stable@...r.kernel.org, linux-serial@...r.kernel.org,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH] sc16is7xx: Drop bogus use of IRQF_ONESHOT

On Mon, 3 Oct 2016 10:14:32 -0500, Julia Cartwright wrote:
> The use of IRQF_ONESHOT when registering an interrupt handler with
> request_irq() is non-sensical.
> ...

Disabling the irq when kthread is pending as mentioned here:

http://www.spinics.net/lists/linux-rt-users/msg14673.html

could be beneficial but this is definitely a step in the right
direction!

Acked-by: Jakub Kicinski <kubakici@...pl>

Thanks a lot Julia!