[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20161013095806.GL5630@mwanda>
Date: Thu, 13 Oct 2016 12:58:06 +0300
From: Dan Carpenter <dan.carpenter@...cle.com>
To: Chris Wilson <chris@...is-wilson.co.uk>,
Daniel Vetter <daniel.vetter@...el.com>,
Ville Syrjälä
<ville.syrjala@...ux.intel.com>, David Airlie <airlied@...ux.ie>,
intel-gfx@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [Intel-gfx] [patch] drm/i915: fix a read size argument
On Thu, Oct 13, 2016 at 10:01:03AM +0100, Chris Wilson wrote:
> On Thu, Oct 13, 2016 at 11:55:08AM +0300, Dan Carpenter wrote:
> > We want to read 3 bytes here, but because the parenthesis are in the
> > wrong place we instead read:
> >
> > sizeof(intel_dp->edp_dpcd) == sizeof(intel_dp->edp_dpcd)
> >
> > which is one byte.
> >
> > Fixes: fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only once on eDP")
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
>
> Oops, does smatch catch this?
Yeah. It does.
regards,
dan carpenter
Powered by blists - more mailing lists