linux-kernel - Re: [PATCH 5/5] i2c: i2c-piix4: coding style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013133440.11b8a61a@endymion>
Date:   Thu, 13 Oct 2016 13:34:40 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Joe Perches <joe@...ches.com>
Cc:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        wsa@...-dreams.de
Subject: Re: [PATCH 5/5] i2c: i2c-piix4: coding style fix - quoted string
 split across lines

On Tue, 11 Oct 2016 19:03:56 -0700, Joe Perches wrote:
> On Tue, 2016-10-11 at 18:34 +0100, Carlos Palminha wrote:
> []
> > diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> []
> > @@ -260,7 +260,8 @@ static int piix4_setup(struct pci_dev *PIIX4_dev,
> >  	else if ((temp & 0x0E) == 0)
> >  		dev_dbg(&PIIX4_dev->dev, "Using SMI# for SMBus\n");
> >  	else
> > -		dev_err(&PIIX4_dev->dev, "Illegal Interrupt configuration "
> > +		dev_err(&PIIX4_dev->dev,
> > +			"Illegal Interrupt configuration "
> >  			"(or code out of date)!\n");
> 
> typically, this format would be coalesced into a single line.

Especially when the patch claims to "fix quoted string split across
lines" :-D

-- 
Jean Delvare
SUSE L3 Support