linux-kernel - Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013133052.3e2296d1@endymion>
Date:   Thu, 13 Oct 2016 13:30:52 +0200
From:   Jean Delvare <jdelvare@...e.de>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     <linux-i2c@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <wsa@...-dreams.de>
Subject: Re: [PATCH 3/5] i2c: i2c-piix4: coding style fix - long comments
 blocks

Hi Carlos,

On Tue, 11 Oct 2016 18:24:39 +0100, Carlos Palminha wrote:
> Signed-off-by: Carlos Palminha <palminha@...opsys.com>
> ---
>  drivers/i2c/busses/i2c-piix4.c | 94 ++++++++++++++++++++++++------------------
>  1 file changed, 54 insertions(+), 40 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-piix4.c b/drivers/i2c/busses/i2c-piix4.c
> index 5d6f637..85b1052 100644
> --- a/drivers/i2c/busses/i2c-piix4.c
> +++ b/drivers/i2c/busses/i2c-piix4.c
> (...)
>  /*
> -   Supports:
> -	Intel PIIX4, 440MX
> -	Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> -	ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> -	AMD Hudson-2, ML, CZ
> -	SMSC Victory66
> -
> -   Note: we assume there can only be one device, with one or more
> -   SMBus interfaces.
> -   The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> -   For devices supporting multiple ports the i2c_adapter should provide
> -   an i2c_algorithm to access them.
> -*/
> + * Supports:
> + *	Intel PIIX4, 440MX
> + *	Serverworks OSB4, CSB5, CSB6, HT-1000, HT-1100
> + *	ATI IXP200, IXP300, IXP400, SB600, SB700/SP5100, SB800
> + *	AMD Hudson-2, ML, CZ
> + *	SMSC Victory66
> + *
> + *  Note: we assume there can only be one device, with one or more

There's an extra space before "Note:", please remove.

> + * SMBus interfaces.
> + * The device can register multiple i2c_adapters (up to PIIX4_MAX_ADAPTERS).
> + * For devices supporting multiple ports the i2c_adapter should provide
> + * an i2c_algorithm to access them.
> + */

-- 
Jean Delvare
SUSE L3 Support