linux-kernel - Re: [PATCH v2] kvm: x86: remove the misleading comment in vmx_handle_external

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161013123612.GE16406@potion>
Date:   Thu, 13 Oct 2016 14:36:13 +0200
From:   Radim Krčmář <rkrcmar@...hat.com>
To:     "Longpeng(Mike)" <longpeng2@...wei.com>
Cc:     pbonzini@...hat.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, x86@...nel.org, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, wu.wubin@...wei.com,
        zhaoshenglong@...wei.com
Subject: Re: [PATCH v2] kvm: x86: remove the misleading comment in
 vmx_handle_external_intr

2016-10-13 10:34+0800, Longpeng(Mike):
> Since Paolo has removed irq-enable-operation in vmx_handle_external_intr
> (KVM: x86: use guest_exit_irqoff), the original comment about the IF bit
> in rflags is incorrect and stale now, so remove it.
> 
> Signed-off-by: Longpeng(Mike) <longpeng2@...wei.com>
> ---
> Hi Radim,
> 
> Changes since v1:
>  - remove this stale comment instead.
> ---

Applied to kvm/queue, thanks.

>  arch/x86/kvm/vmx.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index cf1b16d..e06c8b1 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -8646,11 +8646,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu)
>  	u32 exit_intr_info = vmcs_read32(VM_EXIT_INTR_INFO);
>  	register void *__sp asm(_ASM_SP);
>  
> -	/*
> -	 * If external interrupt exists, IF bit is set in rflags/eflags on the
> -	 * interrupt stack frame, and interrupt will be enabled on a return
> -	 * from interrupt handler.
> -	 */
>  	if ((exit_intr_info & (INTR_INFO_VALID_MASK | INTR_INFO_INTR_TYPE_MASK))
>  			== (INTR_INFO_VALID_MASK | INTR_TYPE_EXT_INTR)) {
>  		unsigned int vector;
> -- 
> 1.8.3.1
> 
>