linux-kernel - Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013140541.GA11758@arch-late.localdomain>
Date:   Thu, 13 Oct 2016 15:05:41 +0100
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linaro-kernel@...ts.linaro.org, linus.walleij@...aro.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead
 of bundle->dev

Hi Viresh,
On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote:
>Some of the print messages are using the incorrect device pointer, fix
>them.
>
>Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

Thanks,
   Rui
>---
> drivers/staging/greybus/gpio.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/drivers/staging/greybus/gpio.c b/drivers/staging/greybus/gpio.c
>index 5e06e4229e42..250caa00de5e 100644
>--- a/drivers/staging/greybus/gpio.c
>+++ b/drivers/staging/greybus/gpio.c
>@@ -702,15 +702,13 @@ static int gb_gpio_probe(struct gbphy_device *gbphy_dev,
> 	ret = gb_gpio_irqchip_add(gpio, irqc, 0,
> 				   handle_level_irq, IRQ_TYPE_NONE);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add irq chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add irq chip: %d\n", ret);
> 		goto exit_line_free;
> 	}
>
> 	ret = gpiochip_add(gpio);
> 	if (ret) {
>-		dev_err(&connection->bundle->dev,
>-			"failed to add gpio chip: %d\n", ret);
>+		dev_err(&gbphy_dev->dev, "failed to add gpio chip: %d\n", ret);
> 		goto exit_gpio_irqchip_remove;
> 	}
>
>-- 
>2.7.1.410.g6faf27b
>