linux-kernel - Re: [GIT PULL] overlayfs update for 4.9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 16:51:46 +0200
From:   Miklos Szeredi <miklos@...redi.hu>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Al Viro <viro@...iv.linux.org.uk>, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-unionfs@...r.kernel.org
Subject: Re: [GIT PULL] overlayfs update for 4.9

On Thu, Oct 13, 2016 at 04:37:51PM +0200, Miklos Szeredi wrote:
> Hi Linus,
> 
> Please pull from:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-linus
> 
> I tried to submit this though Al because of the VFS changes, but failed
> unfortunately.  The VFS changes are small and should only affect overlayfs, so
> here it is.

Forgot to mention that it contains a conflict against the xattr update from
Andreas.  The resolution is to take my version as we now can and should do
permission checks on the underlying layers (with mounter's permission).

Thanks,
Miklos

> 
> This update contains the following changes:
> 
>  - a couple of fixes in the "use mounter's permission to access underlying
>    layers" area;
> 
>  - mnt_want_write_file() should freeze protect the underlying layer, except in
>    the case of i_ops, where the callee is expected to do that
> 
>  - use "clone_file_range" to copy up if possible, resulting in a substantial
>    speedup;
> 
>  - misc fixes and cleanups.
> 
> Thanks,
> Miklos
> 
> ---
> Amir Goldstein (3):
>       vfs: allow vfs_clone_file_range() across mount points
>       vfs: call vfs_clone_file_range() under mnt_want_write()
>       ovl: use vfs_clone_file_range() for copy up if possible
> 
> Miklos Szeredi (7):
>       ovl: copy_up_xattr(): use strnlen
>       ovl: lookup: do getxattr with mounter's permission
>       vfs: mnt_want_write_file() should freeze protect underlying sb
>       ovl: explain error values when removing acl from workdir
>       ovl: use generic_readlink
>       vfs: add vfs_get_link() helper
>       ovl: use vfs_get_link()
> 
> Richard Weinberger (1):
>       ovl: Fix info leak in ovl_lookup_temp()
> 
> Vivek Goyal (1):
>       ovl: during copy up, switch to mounter's creds early
> 
> ---
>  fs/ioctl.c             |  5 +++-
>  fs/namei.c             | 25 +++++++++++++++++
>  fs/namespace.c         |  7 +++--
>  fs/nfsd/vfs.c          |  3 +-
>  fs/open.c              | 15 +++++-----
>  fs/overlayfs/copy_up.c | 75 +++++++++++++++++++-------------------------------
>  fs/overlayfs/dir.c     |  5 +++-
>  fs/overlayfs/inode.c   | 44 +++++++----------------------
>  fs/overlayfs/super.c   | 33 ++++++++++++++--------
>  fs/read_write.c        | 13 ++++-----
>  fs/xattr.c             | 13 ++++++---
>  include/linux/fs.h     | 14 ++++++++++
>  12 files changed, 135 insertions(+), 117 deletions(-)