linux-kernel - Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 19:10:35 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Dave Chinner <david@...morbit.com>, Jan Kara <jack@...e.cz>,
        Nikolay Borisov <kernel@...p.com>,
        "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered)

On 09/26, Oleg Nesterov wrote:
>
> Hello,
>
> The patches do not depend on each other.

Yes,

> 1/2 is the trivial fix, imo -stable material. The bug is very old it seems,
> but today this race (leading to unbalanced unlock)  manifests itself via
> mysterious BUG_ON's in rcu/sync.c.

Yes. Al, could you take it? Or how else we should route it?

> 2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan,
> but the generic/068 test from xfstests triggered the warning. This was fixed by
> dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully
> kill the early-lockdep-release kludge.

Lets ignore it for now, it does lead to false-positives. Thanks again Jan and Dave
for your help.

Oleg.