linux-kernel - Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1476385772.2164.19.camel@perches.com>
Date:   Thu, 13 Oct 2016 12:09:32 -0700
From:   Joe Perches <joe@...ches.com>
To:     Nadim Almas <nadim.902@...il.com>, gregkh@...uxfoundation.org
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line
 limit coding style issue

On Thu, 2016-10-13 at 09:05 -0700, Nadim Almas wrote:
> Fixed coding style issue
> 
> Signed-off-by: Nadim Almas <nadim.902@...il.com>
> ---
>  drivers/staging/ks7010/eap_packet.h | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h
> index df7f760..90432ff 100644
> --- a/drivers/staging/ks7010/eap_packet.h
> +++ b/drivers/staging/ks7010/eap_packet.h
> @@ -58,11 +58,13 @@ struct ieee802_1x_eapol_key {
>  	 * encrypt the Key field; 64-bit NTP timestamp MAY be used here
>  	 */
>  	unsigned char replay_counter[IEEE8021X_REPLAY_COUNTER_LEN];
> -	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];	/* cryptographically random number */
> +	unsigned char key_iv[IEEE8021X_KEY_IV_LEN];
> +	/* cryptographically random number */
>  	unsigned char key_index;	/*
>  					 * key flag in the most significant bit:
>  					 * 0 = broadcast (default key),
> -					 * 1 = unicast (key mapping key); key index is in the
> +					 * 1 = unicast (key mapping key); key
> +					 * index is in the
>  					 * 7 least significant bits
> 

Might be better as
	unsigned char key_index;	/* Key flag:
					 * Most significant bit:
					 * 0: broadcast (default key)
					 * 1: unicast (key mapping key)
					 *    key index is the value of
					 *    the 7 least significant bits
					 */