linux-kernel - Re: [PATCH] [media] rc: Fix uninitialized variable in debug print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161013201551.GA21731@gofer.mess.org>
Date:   Thu, 13 Oct 2016 21:15:51 +0100
From:   Sean Young <sean@...s.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Mauro Carvalho Chehab <mchehab@...pensource.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [media] rc: Fix uninitialized variable in debug print

On Thu, Oct 13, 2016 at 12:35:02PM +0200, Geert Uytterhoeven wrote:
>     drivers/media/i2c/ir-kbd-i2c.c: In function ‘get_key_haup_common’:
>     drivers/media/i2c/ir-kbd-i2c.c:120: warning: ‘toggle’ is used uninitialized in this function
> 
> To fix this, use the intermediate "toggle" variable, like is done in
> other branches.
> 
> Fixes: 00bb820755ed8ee9 ("[media] rc: Hauppauge z8f0811 can decode RC6")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Thanks for finding this and writing a patch.

Acked-by: Sean Young <sean@...s.org>
> ---
>  drivers/media/i2c/ir-kbd-i2c.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/ir-kbd-i2c.c b/drivers/media/i2c/ir-kbd-i2c.c
> index f95a6bc839d58f5f..0ab8e226c4cc0d19 100644
> --- a/drivers/media/i2c/ir-kbd-i2c.c
> +++ b/drivers/media/i2c/ir-kbd-i2c.c
> @@ -114,7 +114,8 @@ static int get_key_haup_common(struct IR_i2c *ir, enum rc_type *protocol,
>  		vendor = get_unaligned_be16(buf + 1);
>  
>  		if (vendor == 0x800f) {
> -			*ptoggle = (dev & 0x80) != 0;
> +			toggle = (dev & 0x80) != 0;
> +			*ptoggle = toggle;
>  			*protocol = RC_TYPE_RC6_MCE;
>  			dev &= 0x7f;
>  			dprintk(1, "ir hauppauge (rc6-mce): t%d vendor=%d dev=%d code=%d\n",
> -- 
> 1.9.1