linux-kernel - RE: [PATCH v4 2/4] fusion: remove iopriority handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 13 Oct 2016 15:05:49 -0600
From:   Sathya Prakash Veerichetty <sathya.prakash@...adcom.com>
To:     Adam Manzanares <adam.manzanares@...t.com>, axboe@...nel.dk,
        tj@...nel.org, dan.j.williams@...el.com, hare@...e.de,
        martin.petersen@...cle.com, mchristi@...hat.com,
        toshi.kani@....com, ming.lei@...onical.com,
        Chaitra Basappa <chaitra.basappa@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>
Cc:     linux-block@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        PDL-MPT-FUSIONLINUX <mpt-fusionlinux.pdl@...adcom.com>,
        linux-scsi@...r.kernel.org,
        Adam Manzanares <adam.manzanares@....com>
Subject: RE: [PATCH v4 2/4] fusion: remove iopriority handling

By removing the code below, we put all the commands for all the types of
devices (SAS/SATA) as simple-Q (requeue as the device require) and I am
not sure whether it is the intention of this change.

-----Original Message-----
From: Adam Manzanares [mailto:adam.manzanares@...t.com]
Sent: Thursday, October 13, 2016 1:54 PM
To: axboe@...nel.dk; tj@...nel.org; dan.j.williams@...el.com;
hare@...e.de; martin.petersen@...cle.com; mchristi@...hat.com;
toshi.kani@....com; ming.lei@...onical.com; sathya.prakash@...adcom.com;
chaitra.basappa@...adcom.com; suganath-prabu.subramani@...adcom.com
Cc: linux-block@...r.kernel.org; linux-ide@...r.kernel.org;
linux-kernel@...r.kernel.org; MPT-FusionLinux.pdl@...adcom.com;
linux-scsi@...r.kernel.org; Adam Manzanares; Adam Manzanares
Subject: [PATCH v4 2/4] fusion: remove iopriority handling

The request priority is now by default coming from the ioc. It was not
clear what this code was trying to do based upon the iopriority class or
data. The driver should check that a device supports priorities and use
them according to the specificiations of ioprio.

Signed-off-by: Adam Manzanares <adam.manzanares@....com>
---
 drivers/message/fusion/mptscsih.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/message/fusion/mptscsih.c
b/drivers/message/fusion/mptscsih.c
index 6c9fc11..4740bb6 100644
--- a/drivers/message/fusion/mptscsih.c
+++ b/drivers/message/fusion/mptscsih.c
@@ -1369,11 +1369,6 @@ mptscsih_qcmd(struct scsi_cmnd *SCpnt)
 	if ((vdevice->vtarget->tflags & MPT_TARGET_FLAGS_Q_YES)
 	    && (SCpnt->device->tagged_supported)) {
 		scsictl = scsidir | MPI_SCSIIO_CONTROL_SIMPLEQ;
-		if (SCpnt->request && SCpnt->request->ioprio) {
-			if (((SCpnt->request->ioprio & 0x7) == 1) ||
-				!(SCpnt->request->ioprio & 0x7))
-				scsictl |= MPI_SCSIIO_CONTROL_HEADOFQ;
-		}
 	} else
 		scsictl = scsidir | MPI_SCSIIO_CONTROL_UNTAGGED;

--
2.1.4

Western Digital Corporation (and its subsidiaries) E-mail Confidentiality
Notice & Disclaimer:

This e-mail and any files transmitted with it may contain confidential or
legally privileged information of WDC and/or its affiliates, and are
intended solely for the use of the individual or entity to which they are
addressed. If you are not the intended recipient, any disclosure, copying,
distribution or any action taken or omitted to be taken in reliance on it,
is prohibited. If you have received this e-mail in error, please notify
the sender immediately and delete the e-mail in its entirety from your
system.