linux-kernel - Re: [PATCH] mm, compaction: allow compaction for GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161013062238.GA21678@dhcp22.suse.cz>
Date:   Thu, 13 Oct 2016 08:22:38 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...e.de>, Joonsoo Kim <js1304@...il.com>,
        Dave Chinner <david@...morbit.com>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm, compaction: allow compaction for GFP_NOFS requests

On Thu 13-10-16 08:19:53, Vlastimil Babka wrote:
> On 10/12/2016 01:47 PM, Michal Hocko wrote:
[...]
> Acked-by: Vlastimil Babka <vbabka@...e.cz>

Thanks!

> 
> Small nitpick below.
> 
> > @@ -1696,14 +1703,16 @@ enum compact_result try_to_compact_pages(gfp_t gfp_mask, unsigned int order,
> >  		unsigned int alloc_flags, const struct alloc_context *ac,
> >  		enum compact_priority prio)
> >  {
> > -	int may_enter_fs = gfp_mask & __GFP_FS;
> >  	int may_perform_io = gfp_mask & __GFP_IO;
> >  	struct zoneref *z;
> >  	struct zone *zone;
> >  	enum compact_result rc = COMPACT_SKIPPED;
> > 
> > -	/* Check if the GFP flags allow compaction */
> > -	if (!may_enter_fs || !may_perform_io)
> > +	/*
> > +	 * Check if the GFP flags allow compaction - GFP_NOIO is really
> > +	 * tricky context because the migration might require IO and
> 
> "and" ?

a leftover from a longer comment. s@ and@.@

Thanks for the review!
-- 
Michal Hocko
SUSE Labs