linux-kernel - Re: [RESEND PATCH 01/11] EDAC, sb_edac: Use Intel family processor macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013220119.jwo52lhvrvuqzgm2@pd.tnic>
Date:   Fri, 14 Oct 2016 00:01:19 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Piotr Luc <piotr.luc@...el.com>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Doug Thompson <dougthompson@...ssion.com>,
        linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
        Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        "Luck, Tony" <tony.luck@...el.com>,
        "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
Subject: Re: [RESEND PATCH 01/11] EDAC, sb_edac: Use Intel family processor
 macros

On Thu, Oct 13, 2016 at 05:30:55PM +0200, Piotr Luc wrote:
> Use macros of Intel processor families instead of raw numbers.
> 
> Signed-off-by: Piotr Luc <piotr.luc@...el.com>
> Reviewed-by: Dave Hansen <dave.hansen@...el.com>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Doug Thompson <dougthompson@...ssion.com>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: linux-edac@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Cc: "Luck, Tony" <tony.luck@...el.com>
> Cc: "Shevchenko, Andriy" <andriy.shevchenko@...el.com>
> ---
>  drivers/edac/sb_edac.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c
> index ce0067b..90564bc 100644
> --- a/drivers/edac/sb_edac.c
> +++ b/drivers/edac/sb_edac.c
> @@ -23,6 +23,7 @@
>  #include <linux/math64.h>
>  #include <linux/mod_devicetable.h>
>  #include <asm/cpu_device_id.h>
> +#include <asm/intel-family.h>
>  #include <asm/processor.h>
>  #include <asm/mce.h>
>  
> @@ -3366,12 +3367,12 @@ fail0:
>  	{ X86_VENDOR_INTEL, 6, model, 0, (unsigned long)&table }
>  
>  static const struct x86_cpu_id sbridge_cpuids[] = {
> -	ICPU(0x2d, pci_dev_descr_sbridge_table),	/* SANDY_BRIDGE */
> -	ICPU(0x3e, pci_dev_descr_ibridge_table),	/* IVY_BRIDGE */
> -	ICPU(0x3f, pci_dev_descr_haswell_table),	/* HASWELL */
> -	ICPU(0x4f, pci_dev_descr_broadwell_table),	/* BROADWELL */
> -	ICPU(0x56, pci_dev_descr_broadwell_table),	/* BROADWELL-DE */
> -	ICPU(0x57, pci_dev_descr_knl_table),		/* KNIGHTS_LANDING */
> +	ICPU(INTEL_FAM6_SANDYBRIDGE_X, pci_dev_descr_sbridge_table),
> +	ICPU(INTEL_FAM6_IVYBRIDGE_X, pci_dev_descr_ibridge_table),
> +	ICPU(INTEL_FAM6_HASWELL_X, pci_dev_descr_haswell_table),
> +	ICPU(INTEL_FAM6_BROADWELL_X, pci_dev_descr_broadwell_table),
> +	ICPU(INTEL_FAM6_BROADWELL_XEON_D, pci_dev_descr_broadwell_table),
> +	ICPU(INTEL_FAM6_XEON_PHI_KNL, pci_dev_descr_knl_table),
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(x86cpu, sbridge_cpuids);
> --

I took Dave's patch here, instead:

https://lkml.kernel.org/r/20160929204321.9FAE5F84@viggo.jf.intel.com

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.