linux-kernel - Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013233742.GA5854@hgst.com>
Date:   Thu, 13 Oct 2016 16:37:43 -0700
From:   Adam Manzanares <adam.manzanares@....com>
To:     Tejun Heo <tj@...nel.org>
CC:     Adam Manzanares <adam.manzanares@...t.com>, <axboe@...nel.dk>,
        <dan.j.williams@...el.com>, <hare@...e.de>,
        <martin.petersen@...cle.com>, <mchristi@...hat.com>,
        <toshi.kani@....com>, <ming.lei@...onical.com>,
        <sathya.prakash@...adcom.com>, <chaitra.basappa@...adcom.com>,
        <suganath-prabu.subramani@...adcom.com>,
        <linux-block@...r.kernel.org>, <linux-ide@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <MPT-FusionLinux.pdl@...adcom.com>,
        <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH v5 4/4] ata: ATA Command Priority Disabled By Default

Hello Tejun,

The 10/13/2016 19:22, Tejun Heo wrote:
> Hello, Adam.
> 
> Sorry about late reply.  Was on vacation.

NP I was on vacation at the end of the week last week.

> 
> On Thu, Oct 13, 2016 at 04:00:31PM -0700, Adam Manzanares wrote:
> > Add a sysfs entry to turn on priority information being passed
> > to a ATA device. By default this feature is turned off.
> > 
> > This patch depends on ata: Enabling ATA Command Priorities
> 
> Looks generally good but can we please use a device attribute name
> which is more specific - ie. enable_ncq_prio?

Will do, I'll also double check the naming scheme of functions and variables 
also. The functions that check if the device has the ncq prio capability might
be too similar to the function that checks if the device attribute is 
enabled.

> 
> Thanks.
> 
> -- 
> tejun

Take care,
Adam