linux-kernel - Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161013072239.GE2774@lahna.fi.intel.com>
Date:   Thu, 13 Oct 2016 10:22:39 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Azhar Shaikh <azhar.shaikh@...el.com>
Cc:     lee.jones@...aro.org, andriy.shevchenko@...el.com,
        heikki.krogerus@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel-lpss: Do not put device in reset state on
 suspend

On Wed, Oct 12, 2016 at 10:12:20AM -0700, Azhar Shaikh wrote:
> Commit 41a3da2b8e163 ("mfd: intel-lpss: Save register context on
> suspend") saved the register context while going to suspend and
> also put the device in reset state.
> 
> Due to the resetting of device, system cannot enter S3/S0ix
> states when no_console_suspend flag is enabled. The system
> and serial console both hang. The resetting of device is not
> needed while going to suspend. Hence remove this code.
> 
> Fixes: 41a3da2b8e163 ("mfd: intel-lpss: Save register context on suspend")
> Signed-off-by: Azhar Shaikh <azhar.shaikh@...el.com>

Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>