linux-kernel - Re: [PATCH] perf: dynamically change verbosity level in perf top

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014154959.GG12815@kernel.org>
Date:   Fri, 14 Oct 2016 12:49:59 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Alexis Berlemont <alexis.berlemont@...il.com>
Cc:     linux-kernel@...r.kernel.org, peterz@...radead.org,
        mingo@...hat.com, alexander.shishkin@...ux.intel.com
Subject: Re: [PATCH] perf: dynamically change verbosity level in perf top

Em Wed, Oct 12, 2016 at 11:48:22PM +0200, Alexis Berlemont escreveu:
> Hi,
> 
> Here is a small patch which tries to fulfill a point in the perf todo
> list:
> 
> * Make pressing 'V' multiple times to go on cycling thru various
>   verbosity levels in 'perf top', so that info that is present in
>   'perf top -v' can be obtained without having to restart the tool
>   (acme).
> 
> After a small grep in the code, the max verbosity level seems 3; so,
> we cycle at 4; I did not dare define a MAX_VERBOSE_LEVEL constant.
 
Works like a charm, thanks for doing this, feel free to go over other
entries in that list :-)

I made changes only in the cset log message, adding the text you wrote
above and adding a:

Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Thanks!

- Arnaldo

> Alexis.
> 
> Alexis Berlemont (1):
>   perf: dynamically change verbosity level in perf top
> 
>  tools/perf/ui/browsers/hists.c |  5 ++++-
>  tools/perf/util/map.c          | 17 ++++++++++++-----
>  2 files changed, 16 insertions(+), 6 deletions(-)
> 
> -- 
> 2.10.0