linux-kernel - Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014160842.GI12815@kernel.org>
Date:   Fri, 14 Oct 2016 13:08:42 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Andi Kleen <andi@...stfloor.org>
Cc:     jolsa@...nel.org, sukadev@...ux.vnet.ibm.com, eranian@...gle.com,
        linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

Em Fri, Oct 14, 2016 at 08:45:15AM -0700, Andi Kleen escreveu:
> > So if we can't convert the scale because of an allocation failure
> > related to locale issues we silently trow it away and do no scale at
> > all?

> That is right. If your machine is thrashing to death in a OOM this
> is your smallest problem.

Please keep it was before, i.e. return an error value, and bail out. It
was like that before, why introduce these kinds of silent "do something
else in an unlikely case" handling?

- Arnaldo