linux-kernel - Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014163641.GJ26852@two.firstfloor.org>
Date:   Fri, 14 Oct 2016 09:36:42 -0700
From:   Andi Kleen <andi@...stfloor.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Andi Kleen <ak@...ux.intel.com>, Andi Kleen <andi@...stfloor.org>,
        jolsa@...nel.org, sukadev@...ux.vnet.ibm.com, eranian@...gle.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/10] perf, tools: Factor out scale conversion code

> I tools/ specifically, I try to use the same constructs, list.h, rbtree,
> WARN_, pr_, etc, not panic()'ing, etc.
> 
> In this specific case, doing a:
> 
>    printf("life is hard, I give up"); exit(1);

Ok that would be just what a wrapper does, only open coded.

How about we just add helpers for these cases?

xstrdup
xmalloc
xasprintf 

etc.

-Andi