linux-kernel - Re: [PATCH 1/2] x86/fpu: remove cpu argument to __cpu_invalidate_fpregs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58010D7E.8050906@linux.intel.com>
Date:   Fri, 14 Oct 2016 09:53:18 -0700
From:   Dave Hansen <dave.hansen@...ux.intel.com>
To:     riel@...hat.com, linux-kernel@...r.kernel.org
Cc:     hpa@...or.com, mingo@...nel.org, bp@...en8.de, luto@...nel.org,
        oleg@...hat.comm
Subject: Re: [PATCH 1/2] x86/fpu: remove cpu argument to
 __cpu_invalidate_fpregs_state

On 10/14/2016 05:15 AM, riel@...hat.com wrote:
> From: Rik van Riel <riel@...hat.com>
> 
> The __{fpu,cpu}_invalidate_fpregs_state functions can only be used
> to invalidate a resource they control.  Document that, and change
> the API a little bit to reflect that.
> 
> Go back to open coding the fpu_fpregs_owner_ctx write in the CPU
> hotplug code, which should be the exception, and move __kernel_fpu_begin
> to this API.
> 
> This patch has no functional changes to the current code.
> 
> Signed-off-by: Rik van Riel <riel@...hat.com>

Looks totally sane to me.

Acked-by: Dave Hansen <dave.hansen@...el.com>