linux-kernel - Re: [PATCH 1/2] watchdog: bcm7038

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161014165548.GA21425@roeck-us.net>
Date:   Fri, 14 Oct 2016 09:55:48 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
        Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 1/2] watchdog: bcm7038_wdt: fix module autoload

On Fri, Oct 14, 2016 at 12:23:50PM -0300, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> $
> 
> After this patch:
> 
> $ modinfo drivers/watchdog/bcm7038_wdt.ko | grep alias
> alias:          of:N*T*Cbrcm,bcm7038-wdtC*
> alias:          of:N*T*Cbrcm,bcm7038-wdt
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
> 
>  drivers/watchdog/bcm7038_wdt.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/bcm7038_wdt.c b/drivers/watchdog/bcm7038_wdt.c
> index e238df4d75a2..4814c00b32f6 100644
> --- a/drivers/watchdog/bcm7038_wdt.c
> +++ b/drivers/watchdog/bcm7038_wdt.c
> @@ -216,6 +216,7 @@ static const struct of_device_id bcm7038_wdt_match[] = {
>  	{ .compatible = "brcm,bcm7038-wdt" },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, bcm7038_wdt_match);
>  
>  static struct platform_driver bcm7038_wdt_driver = {
>  	.probe		= bcm7038_wdt_probe,
> -- 
> 2.7.4
>