linux-kernel - Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed negotiation for Hisilicon Hi6220

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALAqxLWbHF4A0gWrxEQrUsEc6Mj=8-O+VhV85=AD04B5TxAH=Q@mail.gmail.com>
Date:   Fri, 14 Oct 2016 11:22:56 -0700
From:   John Stultz <john.stultz@...aro.org>
To:     Rob Herring <robh+dt@...nel.org>
Cc:     lkml <linux-kernel@...r.kernel.org>, Chen Yu <chenyu56@...wei.com>,
        Wei Xu <xuwei5@...ilicon.com>,
        Guodong Xu <guodong.xu@...aro.org>,
        Amit Pundir <amit.pundir@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        John Youn <johnyoun@...opsys.com>,
        Douglas Anderson <dianders@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux USB List <linux-usb@...r.kernel.org>
Subject: Re: [RFC][PATCH 2/2] usb: dwc2: Add a quirk to allow speed
 negotiation for Hisilicon Hi6220

On Fri, Oct 14, 2016 at 8:00 AM, Rob Herring <robh+dt@...nel.org> wrote:
> On Thu, Oct 13, 2016 at 6:29 PM, John Stultz <john.stultz@...aro.org> wrote:
>> From: Chen Yu <chenyu56@...wei.com>
>>
>> The Hi6220's usb controller is limited in that it does not
>> automatically autonegotiate the usb speed. Thus it requires a
>> quirk so that we can manually negotiate the best usb speed for
>> the attached device.
>>
>> Cc: Wei Xu <xuwei5@...ilicon.com>
>> Cc: Guodong Xu <guodong.xu@...aro.org>
>> Cc: Amit Pundir <amit.pundir@...aro.org>
>> Cc: Rob Herring <robh+dt@...nel.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: John Youn <johnyoun@...opsys.com>
>> Cc: Douglas Anderson <dianders@...omium.org>
>> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
>> Cc: linux-usb@...r.kernel.org
>> Signed-off-by: Chen Yu <chenyu56@...wei.com>
>> Signed-off-by: John Stultz <john.stultz@...aro.org>
>> ---
>>  arch/arm64/boot/dts/hisilicon/hi6220.dtsi |  1 +
>>  drivers/usb/dwc2/core.h                   |  7 +++
>>  drivers/usb/dwc2/hcd.c                    | 75 +++++++++++++++++++++++++++++++
>>  drivers/usb/dwc2/platform.c               |  3 ++
>>  4 files changed, 86 insertions(+)
>>
[snip]
>> diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c
>> index 8e1728b..21c328b 100644
>> --- a/drivers/usb/dwc2/platform.c
>> +++ b/drivers/usb/dwc2/platform.c
>> @@ -585,6 +585,9 @@ static int dwc2_driver_probe(struct platform_device *dev)
>>         dev_dbg(&dev->dev, "mapped PA %08lx to VA %p\n",
>>                 (unsigned long)res->start, hsotg->regs);
>>
>> +       hsotg->change_speed_quirk = device_property_read_bool(&dev->dev,
>> +                               "hi6220,change_speed_quirk");
>
> Can't this be determined from the hi6220's compatible string?

Ah. Good suggestion! I'm moving the quirk field to the core_params.
Should avoid any dts or binding changes.

thanks
-john