lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 15 Oct 2016 08:04:51 +0200 From: Christian Lamparter <chunkeey@...glemail.com> To: Jiri Slaby <jslaby@...e.cz>, linux-kernel@...r.kernel.org Cc: Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] p54: memset(0) whole array On Friday, October 14, 2016 11:23:09 AM CEST Jiri Slaby wrote: > gcc 7 complains: > drivers/net/wireless/intersil/p54/fwio.c: In function 'p54_scan': > drivers/net/wireless/intersil/p54/fwio.c:491:4: warning: 'memset' used with length equal to number of elements without multiplication by element size [-Wmemset-elt-size] > > Fix that by passing the correct size to memset. > > Signed-off-by: Jiri Slaby <jslaby@...e.cz> > Cc: Christian Lamparter <chunkeey@...glemail.com> > Cc: Kalle Valo <kvalo@...eaurora.org> > Cc: linux-wireless@...r.kernel.org > Cc: netdev@...r.kernel.org Acked-by: Christian Lamparter <chunkeey@...glemail.com> > --- > drivers/net/wireless/intersil/p54/fwio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/intersil/p54/fwio.c b/drivers/net/wireless/intersil/p54/fwio.c > index 257a9eadd595..4ac6764f4897 100644 > --- a/drivers/net/wireless/intersil/p54/fwio.c > +++ b/drivers/net/wireless/intersil/p54/fwio.c > @@ -488,7 +488,7 @@ int p54_scan(struct p54_common *priv, u16 mode, u16 dwell) > > entry += sizeof(__le16); > chan->pa_points_per_curve = 8; > - memset(chan->curve_data, 0, sizeof(*chan->curve_data)); > + memset(chan->curve_data, 0, sizeof(chan->curve_data)); > memcpy(chan->curve_data, entry, > sizeof(struct p54_pa_curve_data_sample) * > min((u8)8, curve_data->points_per_channel)); >
Powered by blists - more mailing lists