linux-kernel - Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <67fe262e-31e4-b9dc-da71-af601079bfec@roeck-us.net>
Date:   Sun, 16 Oct 2016 08:50:54 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Sylvain Rochet <sylvain.rochet@...secur.com>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        Boris BREZILLON <boris.brezillon@...e-electrons.com>,
        linux-kernel@...r.kernel.org,
        Nicolas Ferre <nicolas.ferre@...el.com>,
        Ludovic Desroches <ludovic.desroches@...el.com>,
        linux-arm-kernel@...ts.infradead.org
Cc:     stable@...r.kernel.org
Subject: Re: [PATCH] watchdog: at91sam9: keep watchdog running in idle mode

On 10/16/2016 08:33 AM, Sylvain Rochet wrote:
> Hi,
>
> On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote:
>> On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
>>> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
>>> at91sam9_wdt: better watchdog support"), SoCs compatible with
>>> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
>>> times out while the CPU is in idle state. Removing the
>>> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
>>>
>>> Signed-off-by: Sylvain Rochet <sylvain.rochet@...secur.com>
>>> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
>>> Cc: <stable@...r.kernel.org> # 3.14+
>>
>> Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
>>
>> However, we don't really care about that for kernels after 3.18 as no
>> users are using pdata anymore.
>> I think you could send a follow-up patch removing pdata support
>> completely.
>
> Looks like this one falls through the cracks, it didn't reach mainline
> and therefore wasn't applied to stable branches.
>
Possibly that happened because you did not copy the watchdog mailing list.

Guenter

> I just checked, it still apply properly on today's linux-next branch.
>
> Cheers,
> Sylvain
>