linux-kernel - Re: linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20161017083115.GA28881@kroah.com>
Date:   Mon, 17 Oct 2016 10:31:15 +0200
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     David Binderman <dcb314@...mail.com>
Cc:     "oleg.drokin@...el.com" <oleg.drokin@...el.com>,
        "andreas.dilger@...el.com" <andreas.dilger@...el.com>,
        "jsimmons@...radead.org" <jsimmons@...radead.org>,
        "lustre-devel@...ts.lustre.org" <lustre-devel@...ts.lustre.org>,
        "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re:
 linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973: always
 false test ?

On Mon, Oct 17, 2016 at 07:33:33AM +0000, David Binderman wrote:
> Hello there,
> 
> 
> 
> linux-4.9-rc1/drivers/staging/lustre/lustre/osc/osc_request.c:973]: (style) Checking if unsigned variable 'cli.cl_avail_grant' is less than zero.
> 
> 
> 
> Source code is
> 
> 
> 
>    if (cli->cl_avail_grant < 0) {
> 
> 
> 
> Suggest code rework.

Great!  Please send a patch.

thanks,

greg k-h