linux-kernel - Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vawrs4e1.fsf@linux.intel.com>
Date:   Mon, 17 Oct 2016 12:37:10 +0300
From:   Felipe Balbi <felipe.balbi@...ux.intel.com>
To:     Pengcheng Li <lpc.li@...ilicon.com>, johnyoun@...opsys.com
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org, xuejiancheng@...ilicon.com,
        lidongpo@...ilicon.com, caizhiyong@...ilicon.com,
        Pengcheng Li <lpc.li@...ilicon.com>
Subject: Re: [PATCH V2]usb: dwc2: Clear GUSBCFG.UsbTrdTim before setting


Hi,

Pengcheng Li <lpc.li@...ilicon.com> writes:
> The USBTRDTIM field needs to be cleared before setting a new value.
> Otherwise it will result in an incorrect value if phyif == GUSBCFG_PHYIF8.
>
> Change-Id: Ib3e33cf4fd15ada41dc070ff7b93858daafbd10f
> Signed-off-by: Pengcheng Li <lpc.li@...ilicon.com>
> Acked-by: John Youn <johnyoun@...opsys.com>

which commit are you fixing? Seems like you're missing a:

Fixes: foobar ....

line here. Also, you need to remove Gerritisms from commit log ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (801 bytes)