linux-kernel - Re: [PATCH] crygpu/drm/exynos/exynos_hdmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <0147af61-e96e-ba43-55b9-6a58a1539666@samsung.com>
Date:   Mon, 17 Oct 2016 13:33:59 +0200
From:   Andrzej Hajda <a.hajda@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>, airlied@...ux.ie,
        krzk@...nel.org, kgene@...nel.org
Cc:     inki.dae@...sung.com, jy0922.shim@...sung.com,
        sw0312.kim@...sung.com, kyungmin.park@...sung.com,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crygpu/drm/exynos/exynos_hdmi - Unmap region obtained by
 of_iomap


Hi,

On 17.10.2016 13:09, Arvind Yadav wrote:
> Free memory mapping, if hdmi_probe is not successful.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Subject prefix is incorrect.

> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 2275efe..9b7857b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1901,6 +1901,8 @@ err_disable_pm_runtime:
>  err_hdmiphy:
>  	if (hdata->hdmiphy_port)
>  		put_device(&hdata->hdmiphy_port->dev);
> +	if (hdata->regs_hdmiphy)
> +		iounmap(hdata->regs_hdmiphy);

Thats OK, you can add also unmap to hdmi_remove.

Regards
Andrzej

>  err_ddc:
>  	put_device(&hdata->ddc_adpt->dev);
>