linux-kernel - Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdX=La=7i-2HLAoDUzRBSNs5r=gLroDrJBmUzpJJoP+fFw@mail.gmail.com>
Date:   Mon, 17 Oct 2016 16:15:24 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Ralf Ramsauer <ralf@...ses-pyramidenbau.de>
Cc:     Mark Brown <broonie@...nel.org>, Wolfram Sang <wsa@...-dreams.de>,
        Linux SPI <linux-spi@...r.kernel.org>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        "linux-kernel @ vger . kernel . org" <linux-kernel@...r.kernel.org>,
        Pantelis Antoniou <pantelis.antoniou@...sulko.com>
Subject: Re: [PATCH v2 1/2] spi: mark device nodes only in case of successful instantiation

On Mon, Oct 17, 2016 at 3:59 PM, Ralf Ramsauer
<ralf@...ses-pyramidenbau.de> wrote:
> Instantiated SPI device nodes are marked with OF_POPULATE. This was
> introduced in bd6c164. On unloading, loaded device nodes will of course
> be unmarked. The problem are nodes that fail during initialisation: If a
> node fails, it won't be unloaded and hence not be unmarked.
>
> If a SPI driver module is unloaded and reloaded, it will skip nodes that
> failed before.
>
> Skip device nodes that are already populated and mark them only in case
> of success.
>
> Note that the same issue exists for I2C.
>
> Fixes: bd6c164 ("spi: Mark instantiated device nodes with OF_POPULATE")
> Signed-off-by: Ralf Ramsauer <ralf@...ses-pyramidenbau.de>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds