linux-kernel - Re: [PATCH] ARM/orion/gpio: Replace three seq_printf() calls by seq_puts() in orion_gpio_dbg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87a8e3ezx4.fsf@free-electrons.com>
Date:   Mon, 17 Oct 2016 17:52:07 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     SF Markus Elfring <elfring@...rs.sourceforge.net>
Cc:     linux-arm-kernel@...ts.infradead.org, Andrew Lunn <andrew@...n.ch>,
        Jason Cooper <jason@...edaemon.net>,
        Russell King <linux@...linux.org.uk>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] ARM/orion/gpio: Replace three seq_printf() calls by seq_puts() in orion_gpio_dbg_show()

Hi Markus,
 
 On dim., oct. 16 2016, SF Markus Elfring <elfring@...rs.sourceforge.net> wrote:

> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sun, 16 Oct 2016 12:30:48 +0200
>
> Strings which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".
>
> This issue was detected by using the Coccinelle software.
>
Applied on mvebu/drivers

Thanks,

Gregory

> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  arch/arm/plat-orion/gpio.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-orion/gpio.c b/arch/arm/plat-orion/gpio.c
> index f740693..26a531e 100644
> --- a/arch/arm/plat-orion/gpio.c
> +++ b/arch/arm/plat-orion/gpio.c
> @@ -478,13 +478,13 @@ static void orion_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>  			   (data_in ^ in_pol) & msk  ? "hi" : "lo",
>  			   in_pol & msk ? "lo" : "hi");
>  		if (!((edg_msk | lvl_msk) & msk)) {
> -			seq_printf(s, " disabled\n");
> +			seq_puts(s, " disabled\n");
>  			continue;
>  		}
>  		if (edg_msk & msk)
> -			seq_printf(s, " edge ");
> +			seq_puts(s, " edge ");
>  		if (lvl_msk & msk)
> -			seq_printf(s, " level");
> +			seq_puts(s, " level");
>  		seq_printf(s, " (%s)\n", cause & msk ? "pending" : "clear  ");
>  	}
>  }
> -- 
> 2.10.1
>

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com