linux-kernel - Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put() in arche_platform_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161017165117.GA2765@localhost>
Date:   Mon, 17 Oct 2016 18:51:17 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Wei Yongjun <weiyj.lk@...il.com>
Cc:     Vaibhav Hiremath <hvaibhav.linux@...il.com>,
        Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] greybus: arche-platform: Add missing of_node_put()
 in arche_platform_change_state()

On Mon, Oct 17, 2016 at 04:37:20PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@...wei.com>
> 
> This node pointer is returned by of_find_compatible_node() with
> refcount incremented in this function. of_node_put() on it before
> exitting this function.
> 
> This is detected by Coccinelle semantic patch.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

This code is going away eventually, but still.

Acked-by: Johan Hovold <johan@...nel.org>

Thanks,
Johan