linux-kernel - Re: [PATCH v3 net-next 2/2] net: deprecate eth_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161017.131513.135103913948374087.davem@davemloft.net>
Date:   Mon, 17 Oct 2016 13:15:13 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     kubakici@...pl
Cc:     jarod@...hat.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3 net-next 2/2] net: deprecate eth_change_mtu, remove
 usage

From: Jakub Kicinski <kubakici@...pl>
Date: Mon, 17 Oct 2016 18:00:27 +0100

> On Mon, 17 Oct 2016 12:49:54 -0400 (EDT), David Miller wrote:
>> From: Jakub Kicinski <kubakici@...pl>
>> Date: Mon, 17 Oct 2016 17:20:06 +0100
>> 
>> > Please correct me if I'm wrong but it seems like we are now limiting
>> > _all_ ethernet drivers to ETH_DATA_LEN in net-next.  
>> 
>> No, because the driver can increase the netdev->max_mtu value as needed.
> 
> But since almost no driver is doing that, yet, right now in net-next
> jumbo frames are not possible, no?  I thought the idea was the leave
> the value at 0 so drivers can opt-in as needed but since setup_ether()
> is initializing to 1500 now all ethernet driver get a default of
> limiting to 1500.
> 
> IOW this patch made checks which were done only in eth_change_mtu()
> mandatory for all drivers.

The conversions he made were in cases where the driver's method was doing
exactly the same thing eth_change_mtu() does not.

He strictly worked to keep the behavior identical compared to before his
changes, please read his patches carefully.