linux-kernel - [PATCH] xfs: remove redundant assignment of ifp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161017173240.26542-1-colin.king@canonical.com>
Date:   Mon, 17 Oct 2016 18:32:40 +0100
From:   Colin King <colin.king@...onical.com>
To:     Dave Chinner <david@...morbit.com>, linux-xfs@...r.kernel.org,
        "Darrick J . Wong" <darrick.wong@...cle.com>,
        Brian Foster <bfoster@...hat.com>,
        Eric Sandeen <sandeen@...deen.net>
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] xfs: remove redundant assignment of ifp

From: Colin Ian King <colin.king@...onical.com>

Remove redundant ifp = ifp statement, it does nothing. Found with
static analysis by CoverityScan.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 fs/xfs/libxfs/xfs_bmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
index c27344c..0283b7e 100644
--- a/fs/xfs/libxfs/xfs_bmap.c
+++ b/fs/xfs/libxfs/xfs_bmap.c
@@ -5204,7 +5204,7 @@ xfs_bunmapi_cow(
 	ep = xfs_bmap_search_extents(ip, del->br_startoff, XFS_COW_FORK, &eof,
 			&eidx, &got, &new);
 
-	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK); ifp = ifp;
+	ifp = XFS_IFORK_PTR(ip, XFS_COW_FORK);
 	ASSERT((eidx >= 0) && (eidx < ifp->if_bytes /
 		(uint)sizeof(xfs_bmbt_rec_t)));
 	ASSERT(del->br_blockcount > 0);
-- 
2.9.3