linux-kernel - Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Oct 2016 16:08:26 -0500
From:   "Andrew F. Davis" <afd@...com>
To:     Julia Lawall <julia.lawall@...6.fr>
CC:     Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <mmarek@...e.com>, <cocci@...teme.lip6.fr>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Coccinelle: Add misc/boolconv.cocci

On 10/17/2016 03:54 PM, Julia Lawall wrote:
> On Mon, 17 Oct 2016, Andrew F. Davis wrote:
> 
>> Add a script to check for unneeded conversions to bool.
> 
> What changed since the previous version?
> 

Nothing, just a resend, forgot to label it as such.

Andrew

> julia
> 
> 
>>
>> Signed-off-by: Andrew F. Davis <afd@...com>
>> Acked-by: Julia Lawall <julia.lawall@...6.fr>
>> ---
>>  scripts/coccinelle/misc/boolconv.cocci | 90 ++++++++++++++++++++++++++++++++++
>>  1 file changed, 90 insertions(+)
>>  create mode 100644 scripts/coccinelle/misc/boolconv.cocci
>>
>> diff --git a/scripts/coccinelle/misc/boolconv.cocci b/scripts/coccinelle/misc/boolconv.cocci
>> new file mode 100644
>> index 0000000..33c464d
>> --- /dev/null
>> +++ b/scripts/coccinelle/misc/boolconv.cocci
>> @@ -0,0 +1,90 @@
>> +/// Remove unneeded conversion to bool
>> +///
>> +//# Relational and logical operators evaluate to bool,
>> +//# explicit conversion is overly verbose and unneeded.
>> +//
>> +// Copyright: (C) 2016 Andrew F. Davis <afd@...com> GPLv2.
>> +
>> +virtual patch
>> +virtual context
>> +virtual org
>> +virtual report
>> +
>> +//----------------------------------------------------------
>> +//  For patch mode
>> +//----------------------------------------------------------
>> +
>> +@...ends on patch@
>> +expression A, B;
>> +symbol true, false;
>> +@@
>> +
>> +(
>> +  A == B
>> +|
>> +  A != B
>> +|
>> +  A > B
>> +|
>> +  A < B
>> +|
>> +  A >= B
>> +|
>> +  A <= B
>> +|
>> +  A && B
>> +|
>> +  A || B
>> +)
>> +- ? true : false
>> +
>> +//----------------------------------------------------------
>> +//  For context mode
>> +//----------------------------------------------------------
>> +
>> +@r depends on !patch@
>> +expression A, B;
>> +symbol true, false;
>> +position p;
>> +@@
>> +
>> +(
>> +  A == B
>> +|
>> +  A != B
>> +|
>> +  A > B
>> +|
>> +  A < B
>> +|
>> +  A >= B
>> +|
>> +  A <= B
>> +|
>> +  A && B
>> +|
>> +  A || B
>> +)
>> +* ? true : false@p
>> +
>> +//----------------------------------------------------------
>> +//  For org mode
>> +//----------------------------------------------------------
>> +
>> +@...ipt:python depends on r&&org@
>> +p << r.p;
>> +@@
>> +
>> +msg = "WARNING: conversion to bool not needed here"
>> +coccilib.org.print_todo(p[0], msg)
>> +
>> +//----------------------------------------------------------
>> +//  For report mode
>> +//----------------------------------------------------------
>> +
>> +@...ipt:python depends on r&&report@
>> +p << r.p;
>> +@@
>> +
>> +msg = "WARNING: conversion to bool not needed here"
>> +coccilib.report.print_report(p[0], msg)
>> --
>> 2.10.1
>>
>>