linux-kernel - Re: [PATCH 5/5] [media] st-cec: Fix module autoload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2016 09:52:41 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Javier Martinez Canillas <javier@....samsung.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        devel@...verdev.osuosl.org, kernel@...inux.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>
Subject: Re: [PATCH 5/5] [media] st-cec: Fix module autoload

Thanks,

Acked-by: Benjamin Gaignard <benjamin.gaignard@...aro.org>

2016-10-17 17:44 GMT+02:00 Javier Martinez Canillas <javier@....samsung.com>:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
>
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
>
> Before this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> $
>
> After this patch:
>
> $ modinfo drivers/staging/media//st-cec/stih-cec.ko | grep alias
> alias:          of:N*T*Cst,stih-cecC*
> alias:          of:N*T*Cst,stih-cec
>
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
>
> ---
>
>  drivers/staging/media/st-cec/stih-cec.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/media/st-cec/stih-cec.c b/drivers/staging/media/st-cec/stih-cec.c
> index 214344866a6b..19d3ff30c8f8 100644
> --- a/drivers/staging/media/st-cec/stih-cec.c
> +++ b/drivers/staging/media/st-cec/stih-cec.c
> @@ -363,6 +363,7 @@ static const struct of_device_id stih_cec_match[] = {
>         },
>         {},
>  };
> +MODULE_DEVICE_TABLE(of, stih_cec_match);
>
>  static struct platform_driver stih_cec_pdrv = {
>         .probe  = stih_cec_probe,
> --
> 2.7.4
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog