linux-kernel - Re: [PATCH] mm: pagealloc: fix continued prints in show_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2016 14:04:35 +0100
From:   Mark Rutland <mark.rutland@....com>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        Mel Gorman <mgorman@...hsingularity.net>, linux-mm@...ck.org,
        Joe Perches <joe@...ches.com>, Michal Hocko <mhocko@...nel.org>
Subject: Re: [PATCH] mm: pagealloc: fix continued prints in show_free_areas

On Tue, Oct 18, 2016 at 03:00:40PM +0200, Vlastimil Babka wrote:
> On 10/18/2016 01:34 PM, Mark Rutland wrote:
> >In show_free_areas, we miss KERN_CONT in a few cases, and as a result
> >prints are unexpectedly split over a number of lines, making them
> >difficult to read (in v4.9-rc1).
> >
> >This patch uses pr_cont (with uits implicit KERN_CONT) to mark all
> >continued prints that occur withing a show_free_areas() call. Note that
> >show_migration_types() is only called by show_free_areas().
> >Depending on CONFIG_NUMA a printk after show_node() may or may not be a
> >continuation, but follows an explicit newline if not (and thus marking
> >it as a continuation should not be harmful).
> 
> I think this was already fixed:
> 
> http://marc.info/?l=linux-mm&m=147623910031630&w=2

So it was; thanks for the pointer!

Thanks,
Mark.