linux-kernel - Re: [PATCH v2] rtc: cmos: remove all __exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161018141639.owhkvkn4k2rvgspr@piout.net>
Date:   Tue, 18 Oct 2016 16:16:39 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Corentin Labbe <clabbe.montjoie@...il.com>
Cc:     a.zummo@...ertech.it, lars@...afoo.de, rtc-linux@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations

Hi,

On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote :
> Change since v1:
> - restored __exit for module_exit function
> 
> ---8<---

I don't think this is the proper scissor symbol for git. At least, it is
no recognized by patchwork and messes your patch.

> From c04a24acebee4b4432afa7a2a7d4cfe114cc9a40 Mon Sep 17 00:00:00 2001
> From: Corentin Labbe <clabbe.montjoie@...il.com>
> Date: Mon, 17 Oct 2016 14:17:49 +0200
> Subject: [PATCH v2] rtc: cmos: remove all __exit_p annotations
> 
> I got the following stack trace under qemu:

[...]
> When cmos_set_alarm() is called dev is NULL and so trigger the deref via
> cmos->irq
> 
> The problem comes from that the device is removed but no remove function
> are called due to _exit_p().
> 
> This patch remove all _exit_p() annotation.
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> ---


The changelog should go here.

>  drivers/rtc/rtc-cmos.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com