linux-kernel - Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20161018.102935.2077853149914307916.davem@davemloft.net>
Date:   Tue, 18 Oct 2016 10:29:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     niklas.cassel@...s.com
Cc:     larper@...s.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, niklass@...s.com, jespern@...s.com
Subject: Re: [PATCH v2 1/2] dwc_eth_qos: do not clear pause flags from
 phy_device->supported

From: Niklas Cassel <niklas.cassel@...s.com>
Date: Tue, 18 Oct 2016 09:20:33 +0200

> From: Niklas Cassel <niklas.cassel@...s.com>
> 
> phy_device->supported is originally set by the PHY driver.
> The ethernet driver should filter phy_device->supported to only contain
> flags supported by the IP.
> The IP supports setting rx and tx flow control independently,
> therefore SUPPORTED_Pause and SUPPORTED_Asym_Pause should not be cleared.
> If the flags are cleared, pause frames cannot be enabled (even if they
> are supported by the PHY).
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@...s.com>
> Signed-off-by: Jesper Nilsson <jespern@...s.com>
> Acked-by: Lars Persson <larper@...s.com>

Applied.