linux-kernel - [PATCH] x86, pkeys: remove cruft from never-merged syscalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20161018151801.9C33BCC7@viggo.jf.intel.com>
Date:   Tue, 18 Oct 2016 08:18:01 -0700
From:   Dave Hansen <dave@...1.net>
To:     linux-kernel@...r.kernel.org
Cc:     Dave Hansen <dave@...1.net>, dave.hansen@...ux.intel.com,
        tglx@...utronix.de, linux-arch@...r.kernel.org,
        mgorman@...hsingularity.net, arnd@...db.de,
        linux-api@...r.kernel.org, linux-mm@...ck.org, luto@...nel.org,
        akpm@...ux-foundation.org, torvalds@...ux-foundation.org
Subject: [PATCH] x86, pkeys: remove cruft from never-merged syscalls


From: Dave Hansen <dave.hansen@...ux.intel.com>

pkey_set() and pkey_get() were syscalls present in older versions
of the protection keys patches.  The syscall number definitions
were inadvertently left in place.  This patch removes them.

I did a git grep and verified that these are the last places in
the tree that these appear, save for the protection_keys.c tests
and Documentation.  Those spots talk about functions called
pkey_get/set() which are wrappers for the direct PKRU
instructions, not the syscalls.

Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-arch@...r.kernel.org
Cc: mgorman@...hsingularity.net
Cc: arnd@...db.de
Cc: linux-api@...r.kernel.org
Cc: linux-mm@...ck.org
Cc: luto@...nel.org
Cc: akpm@...ux-foundation.org
Cc: torvalds@...ux-foundation.org
Fixes: f9afc6197e9bb ("x86: Wire up protection keys system calls")
---

 b/arch/x86/entry/syscalls/syscall_32.tbl |    2 --
 b/arch/x86/entry/syscalls/syscall_64.tbl |    2 --
 2 files changed, 4 deletions(-)

diff -puN arch/x86/entry/syscalls/syscall_32.tbl~kill-x86-pkey-syscall-nr-cruft arch/x86/entry/syscalls/syscall_32.tbl
--- a/arch/x86/entry/syscalls/syscall_32.tbl~kill-x86-pkey-syscall-nr-cruft	2016-10-17 13:00:11.607811388 -0700
+++ b/arch/x86/entry/syscalls/syscall_32.tbl	2016-10-17 13:00:14.216930557 -0700
@@ -389,5 +389,3 @@
 380	i386	pkey_mprotect		sys_pkey_mprotect
 381	i386	pkey_alloc		sys_pkey_alloc
 382	i386	pkey_free		sys_pkey_free
-#383	i386	pkey_get		sys_pkey_get
-#384	i386	pkey_set		sys_pkey_set
diff -puN arch/x86/entry/syscalls/syscall_64.tbl~kill-x86-pkey-syscall-nr-cruft arch/x86/entry/syscalls/syscall_64.tbl
--- a/arch/x86/entry/syscalls/syscall_64.tbl~kill-x86-pkey-syscall-nr-cruft	2016-10-17 13:00:11.609811480 -0700
+++ b/arch/x86/entry/syscalls/syscall_64.tbl	2016-10-17 13:00:21.896281301 -0700
@@ -338,8 +338,6 @@
 329	common	pkey_mprotect		sys_pkey_mprotect
 330	common	pkey_alloc		sys_pkey_alloc
 331	common	pkey_free		sys_pkey_free
-#332	common	pkey_get		sys_pkey_get
-#333	common	pkey_set		sys_pkey_set
 
 #
 # x32-specific system call numbers start at 512 to avoid cache impact
_