linux-kernel - [tip:efi/core] efi/efi_test: Fix uninitialized variable 'datasize'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2016 08:29:51 -0700
From:   tip-bot for Ivan Hu <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     torvalds@...ux-foundation.org, tglx@...utronix.de, hpa@...or.com,
        peterz@...radead.org, ard.biesheuvel@...aro.org, mingo@...nel.org,
        matt@...eblueprint.co.uk, ivan.khoronzhuk@...aro.org,
        ivan.hu@...onical.com, linux-kernel@...r.kernel.org
Subject: [tip:efi/core] efi/efi_test: Fix uninitialized variable 'datasize'

Commit-ID:  46b9b7135332d1e2c54e853108a5088ab28f2165
Gitweb:     http://git.kernel.org/tip/46b9b7135332d1e2c54e853108a5088ab28f2165
Author:     Ivan Hu <ivan.hu@...onical.com>
AuthorDate: Tue, 18 Oct 2016 15:33:14 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 18 Oct 2016 17:11:17 +0200

efi/efi_test: Fix uninitialized variable 'datasize'

Fix minor issue found by CoverityScan:

  CID 1358931 (#1 of 1): Uninitialized scalar variable (UNINIT)9.
  uninit_use: Using uninitialized value datasize.
  199        prev_datasize = datasize;
  200        status = efi.get_variable(name, vd, at, dz, data);

Signed-off-by: Ivan Hu <ivan.hu@...onical.com>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20161018143318.15673-5-matt@codeblueprint.co.uk
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/test/efi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
index ae51268..348efc9 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -155,7 +155,7 @@ static long efi_runtime_get_variable(unsigned long arg)
 {
 	struct efi_getvariable __user *getvariable_user;
 	struct efi_getvariable getvariable;
-	unsigned long datasize, prev_datasize, *dz;
+	unsigned long datasize = 0, prev_datasize, *dz;
 	efi_guid_t vendor_guid, *vd = NULL;
 	efi_status_t status;
 	efi_char16_t *name = NULL;