linux-kernel - [tip:efi/core] efi/efi_test: Fix uninitialized variable 'rv'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-9c30a2199311df9a1f25d0586c96dfbb7e876cdf@git.kernel.org>
Date:   Tue, 18 Oct 2016 08:30:24 -0700
From:   tip-bot for Ivan Hu <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     matt@...eblueprint.co.uk, linux-kernel@...r.kernel.org,
        ivan.khoronzhuk@...aro.org, hpa@...or.com, mingo@...nel.org,
        peterz@...radead.org, torvalds@...ux-foundation.org,
        ard.biesheuvel@...aro.org, ivan.hu@...onical.com,
        tglx@...utronix.de
Subject: [tip:efi/core] efi/efi_test: Fix uninitialized variable 'rv'

Commit-ID:  9c30a2199311df9a1f25d0586c96dfbb7e876cdf
Gitweb:     http://git.kernel.org/tip/9c30a2199311df9a1f25d0586c96dfbb7e876cdf
Author:     Ivan Hu <ivan.hu@...onical.com>
AuthorDate: Tue, 18 Oct 2016 15:33:15 +0100
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 18 Oct 2016 17:11:18 +0200

efi/efi_test: Fix uninitialized variable 'rv'

Fix minor issue found by CoverityScan:

  520        kfree(name);
  CID 1358932 (#1 of 1): Uninitialized scalar variable (UNINIT)17.
  uninit_use: Using uninitialized value rv.
  521        return rv;
  522}

Signed-off-by: Ivan Hu <ivan.hu@...onical.com>
Signed-off-by: Matt Fleming <matt@...eblueprint.co.uk>
Cc: Ard Biesheuvel <ard.biesheuvel@...aro.org>
Cc: Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: linux-efi@...r.kernel.org
Link: http://lkml.kernel.org/r/20161018143318.15673-6-matt@codeblueprint.co.uk
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 drivers/firmware/efi/test/efi_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/firmware/efi/test/efi_test.c b/drivers/firmware/efi/test/efi_test.c
index 348efc9..bb26e12 100644
--- a/drivers/firmware/efi/test/efi_test.c
+++ b/drivers/firmware/efi/test/efi_test.c
@@ -428,7 +428,7 @@ static long efi_runtime_get_nextvariablename(unsigned long arg)
 	efi_guid_t *vd = NULL;
 	efi_guid_t vendor_guid;
 	efi_char16_t *name = NULL;
-	int rv;
+	int rv = 0;
 
 	getnextvariablename_user = (struct efi_getnextvariablename __user *)arg;