[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20161018162543.zsn5t522lso3e3q7@rob-hp-laptop>
Date: Tue, 18 Oct 2016 11:25:43 -0500
From: Rob Herring <robh@...nel.org>
To: Andrey Smirnov <andrew.smirnov@...il.com>
Cc: linux-gpio@...r.kernel.org,
Linus Walleij <linus.walleij@...aro.org>,
Alexandre Courbot <gnurou@...il.com>,
Mark Rutland <mark.rutland@....com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
cphealy@...il.com
Subject: Re: [PATCH 07/13] bindings: gpio-sx150x: Document "semtech,io-pull*"
bindings
On Mon, Oct 17, 2016 at 07:27:02AM -0700, Andrey Smirnov wrote:
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> ---
> Documentation/devicetree/bindings/gpio/gpio-sx150x.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt b/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> index 02b92ae..7574137 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> +++ b/Documentation/devicetree/bindings/gpio/gpio-sx150x.txt
> @@ -35,6 +35,14 @@ Optional properties:
> polarity. For chips with fewer than 16 IO pins,
> high-end bits are ignored.
>
> +- semtech,io-pullup:
> +- semtech,io-pulldown: A bit-mask which enables-or disables the
> + pull-up (pull-down) resistor for each IO line
> + in the expander. Setting the bit at position n
> + will enable the pull-down for the IO at the
> + corresponding offset. For chips with fewer
> + than 16 IO pins, high-end bits are ignored.
> +
I take my ack back. Please put all DT changes in one patch to review as
a whole. Drivers may evolve with features, but h/w description should
not.
Rob
Powered by blists - more mailing lists