linux-kernel - Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when rx/tx_iface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65e2d1acf20ffc11d4c08e129b862998@codeaurora.org>
Date:   Tue, 18 Oct 2016 11:38:29 -0700
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     kishon@...com, jejb@...ux.vnet.ibm.com, vinholikatti@...il.com,
        martin.petersen@...cle.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Yaniv Gardi <ygardi@...eaurora.org>
Subject: Re: [PATCH v2 01/10] phy: qcom-ufs: remove failure when
 rx/tx_iface_clk are absent

On 2016-10-18 07:28, Vivek Gautam wrote:
> From: Yaniv Gardi <ygardi@...eaurora.org>
> 
> Since in future UFS Phy's the tx_iface_clk and rx_iface_clk
> are no longer exist, we should not fail when their initialization
> fail, but rather just report with debug message.

You may also want to update the device tree binding (documentation) to 
update these as optional properties.

> 
> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
> 
> No change since v1.
> 
>  drivers/phy/phy-qcom-ufs.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/phy/phy-qcom-ufs.c b/drivers/phy/phy-qcom-ufs.c
> index 107cb57..183ec04 100644
> --- a/drivers/phy/phy-qcom-ufs.c
> +++ b/drivers/phy/phy-qcom-ufs.c
> @@ -186,16 +186,27 @@ ufs_qcom_phy_init_clks(struct phy *generic_phy,
>  		       struct ufs_qcom_phy *phy_common)
>  {
>  	int err;
> +	struct ufs_qcom_phy *phy = get_ufs_qcom_phy(generic_phy);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "tx_iface_clk",
>  				   &phy_common->tx_iface_clk);
> +	/*
> +	 * tx_iface_clk does not exist in newer version of ufs-phy HW,
> +	 * so don't return error if it is not found
> +	 */
>  	if (err)
> -		goto out;
> +		dev_dbg(phy->dev, "%s: failed to get tx_iface_clk\n",
> +			__func__);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "rx_iface_clk",
>  				   &phy_common->rx_iface_clk);
> +	/*
> +	 * rx_iface_clk does not exist in newer version of ufs-phy HW,
> +	 * so don't return error if it is not found
> +	 */
>  	if (err)
> -		goto out;
> +		dev_dbg(phy->dev, "%s: failed to get rx_iface_clk\n",
> +			__func__);
> 
>  	err = ufs_qcom_phy_clk_get(generic_phy, "ref_clk_src",
>  				   &phy_common->ref_clk_src);

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project