linux-kernel - Re: [PATCH v2 09/10] scsi/ufs: qcom: Add phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Oct 2016 13:19:13 -0700
From:   Subhash Jadavani <subhashj@...eaurora.org>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     kishon@...com, jejb@...ux.vnet.ibm.com, vinholikatti@...il.com,
        martin.petersen@...cle.com, linux-kernel@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-scsi-owner@...r.kernel.org
Subject: Re: [PATCH v2 09/10] scsi/ufs: qcom: Add phy_exit call in hcd exit
 path

On 2016-10-18 07:28, Vivek Gautam wrote:
> Do a phy_exit() over the ufs phy in the ufs qcom exit path
> to de-initialize the phy.
> 
> Signed-off-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> ---
> 
> New patch added in v2 series.
> 
>  drivers/scsi/ufs/ufs-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index 6e4ce5f..dfd2af8 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -1272,6 +1272,7 @@ static void ufs_qcom_exit(struct ufs_hba *hba)
> 
>  	ufs_qcom_disable_lane_clks(host);
>  	phy_power_off(host->generic_phy);
> +	phy_exit(host->generic_phy);
>  }
> 
>  static int ufs_qcom_set_dme_vs_core_clk_ctrl_clear_div(struct ufs_hba 
> *hba,

LGTM.
Reviewed-by: Subhash Jadavani <subhashj@...eaurora.org>

-- 
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project