linux-kernel - Re: drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j++E0VKf9Vvn0YC+GDU-Bdtu4O0NM9wdbxJM9nZVWJ7sA@mail.gmail.com>
Date:   Tue, 18 Oct 2016 13:57:35 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Emese Revfy <re.emese@...il.com>
Cc:     kbuild test robot <fengguang.wu@...el.com>, kbuild-all@...org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size
 of 1108 bytes is larger than 1024 bytes

On Mon, Oct 17, 2016 at 2:37 PM, Emese Revfy <re.emese@...il.com> wrote:
> On Sun, 16 Oct 2016 06:52:16 +0800
> kbuild test robot <fengguang.wu@...el.com> wrote:
>
>>    drivers/pci/hotplug/ibmphp_ebda.c: In function 'ibmphp_access_ebda':
>> >> drivers/pci/hotplug/ibmphp_ebda.c:409:1: warning: the frame size of 1108 bytes is larger than 1024 bytes [-Wframe-larger-than=]
>
> Hi,
>
> Thanks for the report. The problem is that these are large functions
> (there are a lot of basic blocks) and the entropy plugin instruments all basic blocks.
> I think the solution is to skip these functions which contain more than n basic blocks.
> Sorry, I haven't time to fix this bug. PaX Team will fix it in PaX.

This is controlled by CONFIG_FRAME_WARN. I don't think this is a
particular problem or should be avoided, but perhaps we can set the
default to 2048 (as done on 64BIT) if we're building with the entropy
plugin.

-Kees

-- 
Kees Cook
Nexus Security