linux-kernel - [PATCH] staging: slicoss: replace memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1476826003-1202-1-git-send-email-ryan@ryanswan.com>
Date:   Tue, 18 Oct 2016 17:26:43 -0400
From:   Ryan Swan <ryan@...nswan.com>
To:     devel@...verdev.osuosl.org
Cc:     Ryan Swan <ryan@...nswan.com>, liodot@...il.com,
        charrer@...critech.com, gregkh@...uxfoundation.org,
        LinoSanfilippo@....de, bmarsh94@...il.com,
        amarjargal.gundjalam@...il.com, aquannie@...il.com,
        janani.rvchndrn@...il.com, kevin.m.wern@...il.com,
        linux-kernel@...r.kernel.org
Subject: [PATCH] staging: slicoss: replace memcpy_fromio with memcpy

As per discusion with Lino Sanfilippo, memcpy is the proper way to copy
across dma memory, which also removes sparse warning that triggered
inquiry.

Signed-off-by: Ryan Swan <ryan@...nswan.com>
---
 drivers/staging/slicoss/slicoss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
index 2802b90..9a1dc72 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -1057,7 +1057,7 @@ static void slic_upr_request_complete(struct adapter *adapter, u32 isr)
 		if (stats->rcv_drops > old->rcv_drops)
 			adapter->rcv_drops += (stats->rcv_drops -
 					       old->rcv_drops);
-		memcpy_fromio(old, stats, sizeof(*stats));
+		memcpy(old, stats, sizeof(*stats));
 		break;
 	}
 	case SLIC_UPR_RLSR:
-- 
2.7.4