linux-kernel - Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1610190912580.10204@nippy.intranet>
Date:   Wed, 19 Oct 2016 09:27:34 +1100 (AEDT)
From:   Finn Thain <fthain@...egraphics.com.au>
To:     Arnd Bergmann <arnd@...db.de>
cc:     "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Ondrej Zary <linux@...nbow-software.org>,
        Hannes Reinecke <hare@...e.com>,
        Hannes Reinicke <hare@...e.de>, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: g_NCR5380: add HAS_IOPORT_MAP dependency


On Tue, 18 Oct 2016, Arnd Bergmann wrote:

> The driver was changed to call ioport_map, which breaks platforms that
> cannot provide this function:
> 
> drivers/scsi/g_NCR5380.o: In function `generic_NCR5380_init_one.constprop.0':
> g_NCR5380.c:(.text.generic_NCR5380_init_one.constprop.0+0x388): undefined reference to `ioport_map'
> 
> This adds a Kconfig dependency.
> 
> Fixes: 04c40f82ccc5 ("scsi: g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Acked-by: Finn Thain <fthain@...egraphics.com.au>

> ---
>  drivers/scsi/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 98451fe031a4..3b416c9efe5e 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -744,7 +744,7 @@ config SCSI_ISCI
>  
>  config SCSI_GENERIC_NCR5380
>  	tristate "Generic NCR5380/53c400 SCSI ISA card support"
> -	depends on ISA && SCSI
> +	depends on ISA && SCSI && HAS_IOPORT_MAP
>  	select SCSI_SPI_ATTRS
>  	---help---
>  	  This is a driver for old ISA card SCSI controllers based on a
>