linux-kernel - Re: [PATCH] dmaengine: st_fdma: fix uninitialized variable access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161019125212.GA32299@griffinp-ThinkPad-X1-Carbon-2nd>
Date:   Wed, 19 Oct 2016 13:52:12 +0100
From:   Peter Griffin <peter.griffin@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Vinod Koul <vinod.koul@...el.com>,
        Patrice Chotard <patrice.chotard@...com>,
        Dan Williams <dan.j.williams@...el.com>,
        Ludovic Barre <ludovic.barre@...com>,
        linux-arm-kernel@...ts.infradead.org, kernel@...inux.com,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: st_fdma: fix uninitialized variable access

Hi Arnd,

On Wed, 19 Oct 2016, Arnd Bergmann wrote:

> The newly added st_fdma driver introduces a build warning for
> allmodconfig when we add '-Wmaybe-uninitialized':
> 
> drivers/dma/st_fdma.c: In function 'st_fdma_probe':
> drivers/dma/st_fdma.c:777:5: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> 
> The warning is correct, though this can't happen in practice
> as the check is redundant (we don't get to this function if
> the pointer is NULL). Even if the function were called with a
> NULL of_node, the check is not needed because of_property_read_u32
> can deal with a NULL argument by returning an error.
> 
> Removing the unnecessary code simplifies the function and avoids
> the condition that we get the warning for.
> 
> Fixes: 6b4cd727eaf1 ("dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Acked-by: Peter Griffin <peter.griffin@...aro.org>

regards,

Peter.