linux-kernel - Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8df64b3-79c3-2d69-97b6-ee99d052d22b@baylibre.com>
Date:   Wed, 19 Oct 2016 11:19:39 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Javier Martinez Canillas <javier@....samsung.com>,
        linux-kernel@...r.kernel.org
Cc:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        Kevin Hilman <khilman@...libre.com>,
        PrasannaKumar Muralidharan <prasannatsmkumar@...il.com>,
        Carlo Caione <carlo@...one.org>,
        linux-amlogic@...ts.infradead.org,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Matt Mackall <mpm@...enic.com>,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org
Subject: Re: [PATCH v2] hwrng: meson: Fix module autoload for OF registration

On 10/17/2016 09:51 PM, Javier Martinez Canillas wrote:
> If the driver is built as a module, autoload won't work because the module
> alias information is not filled. So user-space can't match the registered
> device with the corresponding module.
> 
> Export the module alias information using the MODULE_DEVICE_TABLE() macro.
> 
> Before this patch:
> 
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias:          platform:meson-rng
> 
> After this patch:
> 
> $ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
> alias:          platform:meson-rng
> alias:          of:N*T*Camlogic,meson-rngC*
> alias:          of:N*T*Camlogic,meson-rng
> 
> Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> 
> ---
> 
> Changes in v2:
> - Remove unrelated changes added by mistake. Suggested by Jason Gunthorpe.
> 
>  drivers/char/hw_random/meson-rng.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
> index 58bef39f7286..51864a509be7 100644
> --- a/drivers/char/hw_random/meson-rng.c
> +++ b/drivers/char/hw_random/meson-rng.c
> @@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
>  	{ .compatible = "amlogic,meson-rng", },
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, meson_rng_of_match);
>  
>  static struct platform_driver meson_rng_driver = {
>  	.probe	= meson_rng_probe,
> 

Acked-by: Neil Armstrong <narmstrong@...libre.com>