linux-kernel - [PATCH] dmaengine: omap-dma: initialize can

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161019110553.26168-1-colin.king@canonical.com>
Date:   Wed, 19 Oct 2016 12:05:53 +0100
From:   Colin King <colin.king@...onical.com>
To:     Dan Williams <dan.j.williams@...el.com>,
        Vinod Koul <vinod.koul@...el.com>, dmaengine@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org
Subject: [PATCH] dmaengine: omap-dma: initialize can_pause to false

From: Colin Ian King <colin.king@...onical.com>

can_pause is not initialized so it contains garbage.  Fix this
by setting it to false.

Found using static analysis with cppcheck.

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/dma/omap-dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index fd6b9e6..15eb802 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -1286,7 +1286,7 @@ static int omap_dma_pause(struct dma_chan *chan)
 	struct omap_dmadev *od = to_omap_dma_dev(chan->device);
 	unsigned long flags;
 	int ret = -EINVAL;
-	bool can_pause;
+	bool can_pause = false;
 
 	spin_lock_irqsave(&od->irq_lock, flags);
 
-- 
2.9.3